-
Notifications
You must be signed in to change notification settings - Fork 337
Conversation
…th updated deps), more detail in release checklist
Co-authored-by: Brayden Phillips <[email protected]> Co-authored-by: Ashcon Partovi <[email protected]> Co-authored-by: Natalie Davidson <[email protected]> Co-authored-by: Sven Sauleau <[email protected]>
1.14.0 makes more sense to me... did you have a reason to prefer re-publishing? |
to not leave a broken version on npm is all (to be clear, i'm only talking about re-releasing 1.13.0 with the fixed installer that we'll be using from now on, so installing wrangler 1.13.0 from npm will actually do that properly)
…On Wed, Feb 24, 2021 at 11:51 AM Cody Koeninger ***@***.***> wrote:
1.14.0 makes more sense to me... did you have a reason to prefer
re-publishing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1780 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKLUPET52OU3MPSNTKDZ3TAU4CRANCNFSM4YE4TYWQ>
.
|
ff568a5
to
d7d2578
Compare
looks like unfortunately, it seems like the 1.13.0 binary is exiting with status code 1 despite printing no errors, so npx prints a scary error message after running a wrangler command... EDIT: above problem has something to do with clap, and is benign. it only happens when running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Following cloudflare/wrangler-legacy#1780 this should no longer be needed. see #1533.
Following cloudflare/wrangler-legacy#1780 this should no longer be needed. see #1533.
[email protected] broke semver, this PR changes our installer to use a cloudflare-owned version of binary-install with updated dependencies to resolve the previous vulnerability warnings from the old version of axios that was being used.
Question: should we re-publish [email protected] with the fixed installer, or just proceed to 1.14.0?
closes #1772
closes #1286
closes #1234
closes #1758